Exec stsc add #2671
Merged
Exec stsc add #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
force-pushed
the
exec_STSC_add
branch
2 times, most recently
from
f51948d
to
987b478
Compare
fierlion
force-pushed
the
exec_STSC_add
branch
from
987b478
to
0adac31
Compare
angelcar
reviewed
Oct 14, 2020
sharanyad
reviewed
Oct 15, 2020
fierlion
force-pushed
the
exec_STSC_add
branch
2 times, most recently
from
5830ccb
to
3d11623
Compare
fierlion
force-pushed
the
exec_STSC_add
branch
from
971320a
to
be59ebe
Compare
fierlion
force-pushed
the
exec_STSC_add
branch
from
be59ebe
to
ac20c37
Compare
angelcar
reviewed
Oct 20, 2020
fierlion
force-pushed
the
exec_STSC_add
branch
from
ac20c37
to
d3732a8
Compare
angelcar
reviewed
Oct 20, 2020
angelcar
approved these changes
Oct 20, 2020
sharanyad
reviewed
Oct 20, 2020
fierlion
force-pushed
the
exec_STSC_add
branch
2 times, most recently
from
cb0d6f6
to
19ea5d2
Compare
sharanyad
reviewed
Oct 21, 2020
sharanyad
force-pushed
the
feature/ecs_exec
branch
2 times, most recently
from
e709074
to
647eb10
Compare
fierlion
force-pushed
the
exec_STSC_add
branch
from
19ea5d2
to
0b55260
Compare
sharanyad
approved these changes
Oct 21, 2020
angelcar
approved these changes
Oct 21, 2020
fierlion
force-pushed
the
exec_STSC_add
branch
from
0b55260
to
5ebd4d1
Compare
ubhattacharjya
pushed a commit
that referenced
this pull request
Nov 11, 2020
sharanyad
pushed a commit
that referenced
this pull request
Nov 19, 2020
angelcar
pushed a commit
that referenced
this pull request
Nov 19, 2020
fierlion
added a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
Dec 3, 2020
fierlion
added a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
Dec 3, 2020
angelcar
pushed a commit
that referenced
this pull request
Dec 24, 2020
angelcar
pushed a commit
to angelcar/amazon-ecs-agent
that referenced
this pull request
Dec 29, 2020
ubhattacharjya
pushed a commit
that referenced
this pull request
Jan 16, 2021
angelcar
pushed a commit
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds state updates to the exec command manager, and emits a container event for the monitoring of the exec command in the docker task engine.
Implementation details
Exec Command agent status is tracked in the container. I added fields to the ExecCommandAgentMetadata, but kept the actual agent status directly in the container itself. (This might migrate to the Metadata in future, but it breaks a whole lot of tests so I'd prefer to leave it where it is for now.)
Via the execcmd manager, the docker task engine will update the container and metadata state with the
StartedAttime as well as the reason for any error (StoppedReason->ManagedAgent.Reason).The docker task engine will emit the container event during its monitoring cycle.
Testing
Ran All unit tests locally and updated in place.
I'm letting MACIS run the rest and will update as necessary.
New tests cover the changes: yes
Description for the changelog
Update Execute Command Agent state and emit container events for that state.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.