save RCI client token to agent state #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
approved these changes
Nov 6, 2020
fenxiong
reviewed
Nov 6, 2020
fenxiong
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding Register Container Instance's client /registration token to agent state (boltdb only)
This is so that ECS service registers using the same container instance ARN for the container instance that issues quick back to back RCI requests.
Implementation details
Saving new registration token key and value to boltDB
Testing
New tests cover the changes: yes
Manually tested by removing the container instance ARN from boltdb state. Restarted agent and received the same container instance ARN as before.
Description for the changelog
Fix a bug where agent persists RCI client token to avoid being registered as different container instance ARNs.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.