Make create container timeout configurable #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham2892
changed the title
angelcar
reviewed
Jan 4, 2021
mssrivas
reviewed
Jan 4, 2021
README.md
Outdated
| @@ -150,6 +151,7 @@ additional details on each available environment variable. | |||
| | `ECS_ENGINE_TASK_CLEANUP_WAIT_DURATION` | 10m | Time to wait to delete containers for a stopped task. If set to less than 1 minute, the value is ignored. | 3h | 3h | | |||
| | `ECS_CONTAINER_STOP_TIMEOUT` | 10m | Instance scoped configuration for time to wait for the container to exit normally before being forcibly killed. | 30s | 30s | | |||
| | `ECS_CONTAINER_START_TIMEOUT` | 10m | Timeout before giving up on starting a container. | 3m | 8m | | |||
| | `ECS_CONTAINER_CREATE_TIMEOUT` | 10m | Timeout before giving up on creating a container. | 4m | 4m | | |||
There was a problem hiding this comment.
We should mention here what minimum timeout is. Also, it would be helpful if there was a paragraph somewhere explaining how to find best value for use cases
There was a problem hiding this comment.
@mssrivas Unfortunately this will depend on the use case of the customer, for most customers default will be a good value.
angelcar
reviewed
Jan 5, 2021
angelcar
approved these changes
Jan 5, 2021
mssrivas
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make CreateContainerTimeout configurable with a default value of 4 mins.
Implementation details
Testing
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.