bugfix: fix potential deadlock when task updates collide with seelog's string marshalling of tasks #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
previously approved these changes
Feb 18, 2021
fenxiong
previously approved these changes
Feb 18, 2021
to quickly summarize, our logging library (seelog) has the potential to deadlock if a task update happens at the same time as it is trying to unmarshal the task object into a string. long-term we are working to replace this library, but for now we can remove the potential to trigger this deadlock by removing the lock on Task.String(), and remove an unecessary Debug log statement in the AddStateChangeEvent function. - remove lock from Task.String - AddStateChangeEvent: remove log.Debugf statement
sparrc
force-pushed
the
task-string-refactor
branch
from
d47ad92
to
92590fd
Compare
angelcar
approved these changes
Feb 19, 2021
fierlion
approved these changes
Feb 19, 2021
fenxiong
approved these changes
Feb 19, 2021
sparrc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to quickly summarize, our logging library (seelog) has the potential to
deadlock if a task update happens at the same time as it is trying to
unmarshal the task object into a string.
long-term we are working to replace this library, but for now we can
remove the potential to trigger this deadlock by removing the lock on
Task.String(), and remove an unecessary Debug log statement in the
AddStateChangeEvent function.
closes #2802
Description for the changelog
bugfix: fix potential deadlock when task updates collide with seelog's string marshalling of tasks
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.