Support for EXTERNAL launch type (ECS Anywhere) #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to centralize grabbing our instance credential provider into a single package. Previous to this change we grabbed instance credentials in separate places for the ecs, ec2, ecr and ec2 metadata clients. With this change, all of these clients will use the same instance credential provider. The reason for this is that if we want to add any non-default instance credential providers to the credential chain, then we need to make sure that all AWS clients are instantiated with the same provider.
add it into the instance credentials provider chain
When on-prem config is set: 1. Skip adding capabilities that aren't supported on-prem; 2. Add on prem capability; 3. Report cpu architecture as an attribute, obtained from Go runtime.
fenxiong
approved these changes
Apr 20, 2021
angelcar
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rebased the feature/on-prem branch off dev and resolved all conflicts by accepting both changes.
Description for the changelog
Enhancement: Support for ECS EXTERNAL launch type (ECS Anywhere)
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.