V1.52.0 stage #2857
Closed
V1.52.0 stage #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenxiong
reviewed
Apr 28, 2021
we often receive context.Canceled errors when a container exits during docker stats collection. there is a benign race condition where if we process the error first before processing that the context is "Done", then we will log this canceled error as a warning message here: https://github.com/aws/amazon-ecs-agent/blob/5be7aa08bed215a557f48c16d8201ad3db59a9be/agent/stats/container.go#L118-L122 this change ignores these context.Canceled errors so that we don't log them. This will eliminate log messages that look like this when a container exits: level=warn time=2020-12-25T07:51:33Z msg="Error encountered processing metrics stream from docker, this may affect cloudwatch metric accuracy: DockerGoClient: Unable to decode stats for container REDACTED: context canceled" module=container.go
also replace gcr.io ref with a small public.ecr.aws image from ec2
This is to centralize grabbing our instance credential provider into a single package. Previous to this change we grabbed instance credentials in separate places for the ecs, ec2, ecr and ec2 metadata clients. With this change, all of these clients will use the same instance credential provider. The reason for this is that if we want to add any non-default instance credential providers to the credential chain, then we need to make sure that all AWS clients are instantiated with the same provider.
add it into the instance credentials provider chain
When on-prem config is set: 1. Skip adding capabilities that aren't supported on-prem; 2. Add on prem capability; 3. Report cpu architecture as an attribute, obtained from Go runtime.
fenxiong
approved these changes
Apr 28, 2021
chienhanlin
reviewed
Apr 28, 2021
| @@ -1,5 +1,18 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.52.0 | |||
| * Enhancement: Support for ECS EXTERNAL launch type (ECS Anywhere) [#2849](https://github.com/aws/amazon-ecs-agent/pull/2849) | |||
There was a problem hiding this comment.
Could we use - here to unify the format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1.52.0 release staging
Implementation details
Executed as part of managed release process.
Description for the changelog
1.52.0 release stage
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.