adding check to validate default config file path for Windows #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choihca
reviewed
May 13, 2021
rawahars
suggested changes
May 13, 2021
choihca
previously approved these changes
May 13, 2021
vsiddharth
previously approved these changes
May 13, 2021
mythri-garaga
previously approved these changes
May 13, 2021
|
won't this break every customer currently using |
I dont think we ask customers to use /etc/ecs_container_agent/config.json directly anywhere in the docs. We advertise the env variable and ask customers to set this env variable if they want to use a custom config.json |
singholt
changed the title
singholt
dismissed stale reviews from mythri-garaga, vsiddharth, choihca, and rawahars
via
e5874c9
angelcar
reviewed
May 18, 2021
angelcar
previously approved these changes
May 19, 2021
fenxiong
previously approved these changes
May 19, 2021
vsiddharth
reviewed
May 19, 2021
angelcar
approved these changes
May 19, 2021
fenxiong
approved these changes
May 19, 2021
vsiddharth
approved these changes
May 19, 2021
vsiddharth
reviewed
May 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR adds a check to validate the default agent config file path on Windows.
Currently, the default config file path on Windows is
"C:/etc/ecs_container_agent/config.json". We're adding a check to validate whether the admin has created the config file or not. Note that this check is not done if the envECS_AGENT_CONFIG_FILE_PATHis set, since it overrides the default config file.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.