EC2 task networking for Windows: Build vpc-eni plugin #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 18:13
…k stats. Initially, without any network, pause container returns nil network stats. When container stats are collected with pause namespace in place, lastStats.NetworkStats is nil which causes agent to crash and restart.
angelcar
approved these changes
May 19, 2021
angelcar
approved these changes
May 20, 2021
singholt
approved these changes
May 20, 2021
|
This PR is dependent upon the CNI plugin PR (aws/amazon-vpc-cni-plugins#52). Until that PR is merged, the build will fail for this one. |
|
These changes are now part of #2876 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The primary changes made in this PR are-
vpc-eniCNI plugin for WindowsImplementation details
vpc-eniCNI pluginTesting
A custom binary was built and tested.
New tests cover the changes:
No new functionality has been added
Description for the changelog
Build
vpc-eniCNI plugin for Windows task networking.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.