Avoid making checkpoint config Explicitlydisabled when ECS_DATADIR is…

[angelcar]

Summary

Fixes #2850

There was a bug inparseCheckpoint, which incorrectly set the Checkpoint config as ExplicitlyDisabled when the data directory config was not set. This prevented the Checkpoint config to be overridden by other configuration methods, such as configuration file. Please refer to #2850 for more details

Implementation details

Remove the incorrect assignation of ExplicitlyDisabled

Testing

Tested in personal account that the checkpoint is picked up correctly after this change. Made sure it's backwards compatible.

New tests cover the changes: yes

Description for the changelog

• Fixes DataDir/Checkpoint file configuration is broken #2850

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[shubham2892]

🚢

[fierlion]

amazon-ecs-agent/agent/config/conditional.go

Lines 74 to 77 in 2874131

	/// Enabled is a convenience function for when consumers don't care if the value is implicit or explicit
	func (b BooleanDefaultFalse) Enabled() bool {
	return b.Value == ExplicitlyEnabled
	}

there it is. So this ends up true to the original intent when NotSet