Update windows builds to golang v1.17 #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
vsiddharth
force-pushed
the
update-windows-golang-v117
branch
from
fcfeb94
to
88f60dc
Compare
angelcar
reviewed
Sep 1, 2021
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
|
|
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
This test has been quite flaky but after the recent changes, this test appears to be fine. |
Signed-off-by: Siddharth Vinothkumar <sidvin@amazon.com>
vsiddharth
force-pushed
the
update-windows-golang-v117
branch
from
a683105
to
a33c30c
Compare
angelcar
approved these changes
Sep 8, 2021
singholt
reviewed
Sep 8, 2021
sharanyad
approved these changes
Sep 8, 2021
singholt
approved these changes
Sep 9, 2021
chienhanlin
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update agent builds for windows to use golang v1.17
Implementation details
golang.org/x/sys v0.0.0-20190830141801-acfa387b8d69Testing
An EC2 container instance was setup manually:
New tests cover the changes: Yes
Description for the changelog
Enhancement - Update windows builds to golang version v1.17
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.