Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.17.2 upgrade #3057

Merged
merged 8 commits into from
Oct 12, 2021
Merged

Go1.17.2 upgrade #3057

merged 8 commits into from
Oct 12, 2021

Conversation

sharanyad
Copy link
Contributor

@sharanyad sharanyad commented Oct 8, 2021

Summary

This upgrades Go version for building ECS agent (both Linux and Windows) to 1.17.2 (latest).

Implementation details

  1. Ran goimports (// +build to //go:build) to fix static check failures
  2. Ran gogenerate (os "os" to fs "io/fs") to fix static check failures
  3. Use GO111MODULE=auto wherever necessary since go mod is the default in the latest versions
  4. Today, customers can set HTTP_PROXY and HTTPS_PROXY proxy configurations in the /etc/ecs/ecs.config file. Latest Go includes a security fix to the net/http package, and one of the changes is the ProxyFromEnvironment function no longer returns the setting of the HTTP_PROXY environment variable for https when HTTPS_PROXY is unset.
    To update the internal proxy config after Agent has been initialized, having the http client to check for proxy environment variables for every request is necessary. Used from fenxiong@f231f86
    TestSquidProxy was failing due to the backward breaking change, this set of changes fixes it

Testing

New tests cover the changes: yes

Description for the changelog

N/A

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sharanyad sharanyad changed the title [wip] Go1.17.2 upgrade Go1.17.2 upgrade Oct 11, 2021
@sharanyad sharanyad marked this pull request as ready for review October 12, 2021 00:05
angelcar
angelcar previously approved these changes Oct 12, 2021
Copy link
Contributor

@angelcar angelcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only outstanding thing is the // +build linux tag, but lgtm otherwise

Copy link
Contributor

@fenxiong fenxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sharanyad sharanyad merged commit 225e27c into aws:dev Oct 12, 2021
@ubhattacharjya ubhattacharjya added this to the 1.55.5 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants