Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps github.com/containerd/containerd from 1.3.2 to 1.4.11 #3073

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

yinyic
Copy link
Contributor

@yinyic yinyic commented Oct 28, 2021

Summary

Bumps github.com/containerd/containerd as a result of this Dependabot issue

Implementation details

go mod tidy
go mod vendor

Testing

make test
New tests cover the changes: N/A

Description for the changelog

Bumps github.com/containerd/containerd from 1.3.2 to 1.4.11

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@angelcar
Copy link
Contributor

it's a bit weird that the only thing that seems to have changed is agent/vendor/github.com/containerd/containerd/errdefs/errors.go

@yinyic
Copy link
Contributor Author

yinyic commented Oct 28, 2021

it's a bit weird that the only thing that seems to have changed is agent/vendor/github.com/containerd/containerd/errdefs/errors.go

Looking at vendor directory, we are only taking two source files from github.com/containerd/containerd https://github.com/aws/amazon-ecs-agent/tree/dev/agent/vendor/github.com/containerd/containerd, errors.go and grpc.go. I wonder if that could explain it?

@angelcar
Copy link
Contributor

oh, maybe because 1.4.11 still does not use go modules 🤔

@yinyic yinyic merged commit 49c1a34 into aws:dev Oct 28, 2021
@yinyic yinyic deleted the containerd_bump branch October 28, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants