added support for metrics when using awsvpc mode on Windows #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry75
reviewed
Nov 12, 2021
jterry75
reviewed
Nov 12, 2021
jterry75
reviewed
Nov 12, 2021
jterry75
reviewed
Nov 12, 2021
jterry75
reviewed
Nov 12, 2021
angelcar
reviewed
Nov 12, 2021
angelcar
previously approved these changes
Nov 15, 2021
angelcar
reviewed
Nov 15, 2021
angelcar
previously approved these changes
Nov 15, 2021
angelcar
previously approved these changes
Nov 15, 2021
jterry75
previously approved these changes
Nov 15, 2021
Currently, the metrics support was available only for tasks running in default mode on Windows. The changes introduced in this commit extends this support for tasks running in awsvpc network mode as well.
|
Rebased the PR over latest dev. No other changes in the last force push. |
angelcar
approved these changes
Nov 16, 2021
jterry75
approved these changes
Nov 16, 2021
fierlion
approved these changes
Nov 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the metrics support was available only for tasks running in default mode on Windows. The changes introduced in this PR extends this support for tasks running in awsvpc network mode as well.
Implementation details
For Windows,
Get-NetAdapterStatisticscommand is invoked for the given task ENI and the stats from the same are recorded. The existing Linux workflow is leveraged by segregating them into Windows and Linux platform specific files.Testing
Unit and integ tests were ran. Additionally, a custom agent binary was tested on WS 2016, 2019, and 2022.
New tests cover the changes:
Yes
Description for the changelog
Added support for metrics when using awsvpc network mode on Windows
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.