Lower task cleanup duration #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelcar
force-pushed
the
lower-task-clanup-duration
branch
from
61b9148
to
1f0485b
Compare
sparrc
approved these changes
Nov 15, 2021
lydiafilipe
approved these changes
Nov 15, 2021
| @@ -92,7 +92,7 @@ const ( | |||
|
|
|||
| // minimumTaskCleanupWaitDuration specifies the minimum duration to wait before cleaning up | |||
| // a task's container. This is used to enforce sane values for the config.TaskCleanupWaitDuration field. | |||
| minimumTaskCleanupWaitDuration = 1 * time.Minute | |||
| minimumTaskCleanupWaitDuration = time.Second | |||
There was a problem hiding this comment.
LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?
There was a problem hiding this comment.
I think it was an entirely arbitrary decision. I tested various scenarios and 1s seems to work fine.
At any rate, this is just the minimum allowed value and it will only be used if customer deems it useful.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lower minimum task clean up duration from one minute to one second.
This could help mitigate #2810
Testing
UTs, Integ & functinal tests
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.