Add Host IP to port response for v2 container response #3112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently there is no way to identify ipv4 ports vs ipv6 ports from Task metadata endpoint v4. This PR includes changes to add Host IP to port response for Task metadata endpoint v2 onwards.
Related to issue - #3096
Implementation details
agent/handlers/v1/response.go
: update PortResponse struct to include HostIp field.agent/handlers/v2/response.go
: add HostIp to container response and update tests accordingly.Testing
Tested this change by running a task with container port mappings configured on a IPv6 enabled instance and see the following response for
curl ${ECS_CONTAINER_METADATA_URI_V4}/task
New tests cover the changes: yes
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.