Init integration foundation #3138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge gpu-support branch into dev branch
Update systemd unit description and add url
remove references to DHClient
This is needed as the aws-appmesh cni plugin needs to invoke `iptables` command. The ECS agent container doesn't have the necessary lib and binary paths to invoke this command. The additional volume mounts /sbin, /usr/lib64, /lib64 help with that.
Add binding for agent container to be able to run iptables.
iptables also relies on these libraries in order to execute successfully
Adding "/lib" and "/usr/lib" to the binds
Some usages of agent will require the agent container to have permissions elevated beyond cap NET_ADMIN. This can now be accessed by modifying the following environment variable and invoking ecs-init: ` export ECS_AGENT_RUN_PRIVILEGED=true ` This is not recommended for general use and may be removed in future versions of ecs-init.
* Cache agent 1.26.1
Merge master back to dev after 1.28.0 release
User existing backoff package Change Info log message to Warn add variable names to NewBackoff arguments
This reverts commit 39c2e57.
This lets us use the command `make rpm-in-docker` to build locally. This is a good approximation of an authorative build that we can use to test changes to init.
build al2 rpm in docker
angelcar
approved these changes
Feb 26, 2022
|
closing in favor of the updated PR against the latest (post release 1.60): #3141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the initial commit to begin integrating ECS Init into ECS Agent; we'll be building the rest of our init integrations on top of this PR's changes, but we want to merge the present changes to allow for future rebases against dev branch.
See the proposal here: aws/amazon-ecs-init#482
Note that the Commit SHAs in the history are not changed and that the Agent and Init commits are interleaved by date.
Implementation details
To create this PR, I cloned https://github.com/aws/amazon-ecs-init.git and checked out the dev branch.
(For safety, I deleted the remote using
git remote rm origin).I renamed/removed the following set of files from init as they collided with existing files in agent:
I then cleaned the init repo:
I then cloned https://github.com/aws/amazon-ecs-agent.git and checked out the dev branch
I set the ecs-init repo as a remote
git remote add init-repo ../amazon-ecs-init/and pulled the changes from my init branch into agent with included history:git pull init-repo initIntegration --allow-unrelated-histories.Description for the changelog
Base changes to integrate ECS Init into ECS Agent.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.