Fix potential goroutine leaks #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending to an unbuffered channel without a select and without a guarantee that something will receive from that channel, is a recipe for a gourutine leak. Make the channel buffered to avoid it. Also, with a buffered channel, no need to spin up a new goroutine to begin with. Just send right after channel creation.
nodir-t
changed the title
angelcar
approved these changes
Apr 15, 2022
fierlion
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes potential minor goroutine leaks.
Implementation details
Sending to an unbuffered channel without a
selectand without a guarantee that somethingwill receive from that channel, is a recipe for a goroutine leak.
Make the channel buffered to avoid the issue.
Also, with a buffered channel, there is no no need to spin up a new goroutine just to send a
dummy object into it. Instead, just send right after channel creation.
Testing
New tests cover the changes: no
Description for the changelog
Fix potential goroutine leaks
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.