Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max task reason to 1024 characters #3229

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

angelcar
Copy link
Contributor

Summary

Trimming task reason to a max of 1024 characters as per Back-end model.

Implementation details

  • Renamed existing constant that defines a max reason of 255 characters to be container-specific
  • Added new constant to limit max reason for the task, as opposed to container's reason
  • Reusing existing string trimming function

Testing

UTs
Functional Tests

New tests cover the changes: yes

Description for the changelog

  • Enhancement - Trimming task reason to a max of 1024 characters as per Back-end model.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ubhattacharjya ubhattacharjya merged commit a7818bf into aws:dev Jun 1, 2022
@ubhattacharjya ubhattacharjya added this to the 1.61.2 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants