Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceName to task #3342

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Add ServiceName to task #3342

merged 2 commits into from
Aug 16, 2022

Conversation

amogh09
Copy link
Contributor

@amogh09 amogh09 commented Aug 16, 2022

Summary

  1. Update ACS Client library. ACS now sends ServiceName in task payloads.
  2. Load ServiceName from ACS Task payload into Agent's Task type. TMDE will be updated in the future to add ServiceName in task responses.

Testing

Updated unit tests. MACIS functional tests.

New tests cover the changes: yes

Description for the changelog

Load ServiceName from ACS Task Payload.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Realmonia
Realmonia previously approved these changes Aug 16, 2022
@amogh09 amogh09 changed the base branch from master to dev August 16, 2022 20:24
@amogh09 amogh09 dismissed stale reviews from YashdalfTheGray and Realmonia August 16, 2022 20:24

The base branch was changed.

@amogh09 amogh09 merged commit dc450e8 into aws:dev Aug 16, 2022
@amogh09 amogh09 deleted the service-arn-from-acs branch August 16, 2022 21:31
YashdalfTheGray pushed a commit that referenced this pull request Aug 17, 2022
* Add ServiceName to task

* Update windows unit tests

Co-authored-by: Amogh Rathore <amoghr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants