Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update healthcheck and ports #3343

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

fierlion
Copy link
Member

Summary

This contains various release related fixes:

  • add healthcheck and expose required ports.
  • Update short hash to consistent length
  • add init release version (-1 hard coded for now with TODO)

Implementation details

The changes are made in the codebuild steps as well as in the agent-container config file which we use to build our agent container.

Testing

$ sudo systemctl stop ecs
$ make dockerfree-agent-image # creates ecs-agent-v1.62.1.tar
$ docker load < ecs-agent-v1.62.1.tar # retags as latest automatically
$ sudo systemctl start ecs
$ docker ps # to see the healthcheck in action

CONTAINER ID   IMAGE                            COMMAND    CREATED          STATUS                    PORTS     NAMES
0c052108c229   amazon/amazon-ecs-agent:latest   "/agent"   39 seconds ago   Up 37 seconds (healthy)             ecs-agent

$ docker images # to find the latest image id
$ docker inspect

...
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "51678/tcp": {},
                "51679/tcp": {}
            },
...

New tests cover the changes: no

Description for the changelog

Update healthcheck and ports in dockerfree build.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fierlion fierlion changed the base branch from master to dev August 16, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants