Add types for task protection handlers #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienhanlin
reviewed
Aug 19, 2022
chienhanlin
reviewed
Aug 20, 2022
chienhanlin
reviewed
Aug 20, 2022
chienhanlin
approved these changes
Aug 22, 2022
Realmonia
reviewed
Aug 22, 2022
| // Protection for a Task | ||
| type taskProtection struct { | ||
| protectionType taskProtectionType | ||
| protectionTimeoutMinutes *int |
There was a problem hiding this comment.
Q: What's the consideration of making this *int instead of int? Is this in sync with scheduler API?
Realmonia
approved these changes
Aug 22, 2022
amogh09
added a commit
that referenced
this pull request
Aug 24, 2022
amogh09
added a commit
that referenced
this pull request
Aug 30, 2022
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
Sep 13, 2022
Realmonia
pushed a commit
that referenced
this pull request
Sep 14, 2022
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
Oct 4, 2022
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
Oct 4, 2022
Realmonia
pushed a commit
that referenced
this pull request
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new types to be used in Task scale-in protection API handlers.
Implementation details
A couple of new types, their constructors, and getters.
Testing
Unit tests
New tests cover the changes: yes
Description for the changelog
Add new types for task scale-in protection API
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.