Reduce the flakiness of a windows integration test TestExecCommandAgent #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
amogh09
changed the title
amogh09
changed the title
…r a stopped process
amogh09
force-pushed
the
fix-win-integ-test-exec-command
branch
from
3f3109f
to
1a89c36
Compare
arun-annamalai
approved these changes
Aug 25, 2022
jterry75
approved these changes
Aug 25, 2022
sparrc
approved these changes
Aug 25, 2022
fierlion
approved these changes
Aug 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TestExecCommandAgentcurrently issues a kill command for a process running inside a container and sleeps for 4 seconds hoping for the process to be killed. This test has been failing lately because the process to be killed is still running for some time after 4 seconds.This change replaces the 4 second sleep with a loop that checks every second if the process was killed. The loop timeouts after 15 seconds.
Testing
Tested by running the test on a Windows EC2 instance. Also the test is run as a part of PR checks.
New tests cover the changes: NA
Description for the changelog
Reduce the flakiness of TestExecCommandAgent.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.