Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable default profile #3365

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

fierlion
Copy link
Member

@fierlion fierlion commented Aug 26, 2022

Summary

Update to allow for a configurable alternate credential profile other than default.
#3241

Implementation details

Add a new env var, ECS_ALTERNATE_CREDENTIAL_PROFILE, to allow for overriding the default credential profile.

Testing

built agent with existing logging in place. updated /etc/ecs/ecs.config to add

ECS_ALTERNATE_CREDENTIAL_PROFILE="testProfile"

checked info level logs for the override message.

New tests cover the changes: yes

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@Realmonia Realmonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sorry for my poor English but can you help me understand why you choose alternate over alternative? Thanks!

Edit: nvm I kinda understand it - the idea you want to convey here is it is not another optional but an override. Not sure if there are better word options to avoid the confusion that this is going to be used as a backup profile - considering it is not a back up but an override.

@fierlion
Copy link
Member Author

nit: sorry for my poor English but can you help me understand why you choose alternate over alternative? Thanks!

They're essentially synonyms.

'alternate is frequently used to mean "offering or expressing a choice." There are established uses for both that we regularly encounter: a director's cut of a film may feature an alternate ending; a traffic update warns motorists to seek an alternate route.
Many examples, though, use the word simply to mean "offering a choice apart from what is traditional or expected'

https://www.merriam-webster.com/words-at-play/differences-between-alternate-and-alternative

@fierlion fierlion merged commit 412097c into aws:dev Aug 29, 2022
@fierlion fierlion deleted the fierlion/addConfigurableDefault branch August 29, 2022 21:35
@chienhanlin chienhanlin mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants