Change JSON key for VPC ID in TMDE v4 TaskResponse from VpcId to VPCID #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for consistency with existing keys.
singholt
approved these changes
Sep 9, 2022
fierlion
approved these changes
Sep 9, 2022
ubhattacharjya
approved these changes
Sep 9, 2022
Merged
chienhanlin
pushed a commit
that referenced
this pull request
Sep 12, 2022
dependabot bot
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Oct 1, 2022
dependabot bot
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Oct 5, 2022
dependabot bot
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Oct 5, 2022
dependabot bot
added a commit
to rawahars/amazon-ecs-agent
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing the JSON key used for VPC ID field in TMDE v4 TaskResponse from
VpcIdtoVPCIDas suggested by Tech Documentation team. The idea is to use all uppercase for abbreviations.Testing
Tested by sending curl requests to Agent.
New tests cover the changes: NA
Description for the changelog
Change JSON key for VPC ID in TMDE v4 TaskResponse to VPCID
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.