Extend the TaskEngine interface with the GetTaskByArn method #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you regenerate the mocks? |
|
Yeah, noticed that. Regenerating mocks now. |
|
Updated PR now passes tests. r? @samuelkarp @juanrhenals |
|
👍 |
| @@ -54,6 +54,10 @@ func (engine *MockTaskEngine) ListTasks() ([]*api.Task, error) { | |||
| return nil, nil | |||
| } | |||
|
|
|||
| func (engine *MockTaskEngine) GetTaskByArn(arn string) (*api.Task, bool) { | |||
There was a problem hiding this comment.
Nit: is there any particular reason why you're returning a bool type here instead of just using error?
There was a problem hiding this comment.
Yeah, just following the map lookup semantics in golang.
|
Just had one nit. LGTM 👍 |
aaithal
added a commit
that referenced
this pull request
Mar 15, 2016
Extend the TaskEngine interface with the GetTaskByArn method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @samuelkarp @juanrhenals