Feature/service connect #3414
Merged
Feature/service connect #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Service Connect egress VIP to pause container host config
Refactor out ServiceConnect from task engine
Add support for mapping relay parameters into task
Adding runtime configuration to ServiceConnect block
* Use pause container for SC container, let each pause container invoke CNI plugin individually * Fix docker engine test race condition
There were 2 functions in apiTask that had complexitiy above 15; docketHostConfig and PostUnMarshalTask. Reducing the complexity was done by combining the dependency ordering of volumes and links, moving the conditional of Memory / CPU limits into the platform specific implementations of initializeCgroupResourceSpec, and modifying PIDMode and IPCMode inside the checking functions instead of in the outer function.
* Add Appnet Client * Invoke Appnet's Drain Connections API on task shutdown * Integrate Appnet's GetStats with Stats engine
The AppNet Agent client is reponsible for the model handling of communicating with the AppNet Agent container, but it should treat the connection information as configuration coming from the task. This allows for changes with AppNet Agent versions to be encoded in the ServiceConnect Manager only. Different http flags or similar should go with the Container not static with Agent version. This simply moves the path information back into the Task which is populated by the ServiceConnect Manager.
…bled tasks running in bridge mode (#3293)
* Add AppNetLoader into task engine * Add ability to get Image from loader * Add support for starting Relay
* Minor updates for bootstrapping AppNet Relay task/container * fix typo
* Move the service connect loader into manager Since the loader is only used within the manager encapsulate it there. * Make docker task engine agnostic to loader
* Adding a common Loader interface This interface is currently in use in 2 places and those use cases will be consolidated to this interface * Migrate the agent/eni/pause to new interface Migrating the agent/eni/pause usecase over to the new agent/utils/loader * Migrate the agent/serviceconnect to new interface Migrating the agent/serviceconnect usecase over to the new agent/utils/loader
* SC attachment fixes; Use network mode from ACS payload * Fix windows integ test * Add case for None network mode * Add back creating SC config through ENV
Set all expectations up front before running. Also tie the same operation together with inOrder since they accept gomock.Any() which means their order isn't guaranteed. Also if the engine describes the Agent container after start it should return HEALTHY so that the task container will start.
…e; fix AppNet container pull error (#3329) * Run AppNet Relay as non-privileged user * Add filter for internal tasks during task retrieval * Skip image pulling for AppNet containers * Fix unit test * Keep the existing usage for allTasksUnsafe, but extract the body to a new function that takes a flag to exclude internal tasks
* Update AppNet UID from 1337 to 20000 * Add ECS_CONTAINER_INSTANCE_ARN ENV for AppNet Agent container
…setting (#3390) * Fix AppNet Relay health check configuration * Fix invocation for ServiceConnect manager property setter
…3403) * Write AppNet logs to /var/log/ecs/ if no logging driver configured * Source ECS Agent log container path from ECS_LOGFILE env if present
yinyic
approved these changes
Oct 4, 2022
singholt
approved these changes
Oct 4, 2022
|
Hi there, where can I found the documentation for this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merge feature/service-connect branch to dev.
All pull requests have been previously approved by aws-ecs-agent reviewer team
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Feature - Add service connect feature. This feature enables ECS Service to be discoverable and ECS will leverage the container port mappings, service name and default application namespace associated with the cluster and the service to register your service for discovery and to enable discovery of dependencies through DNS lookup.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.