Update defaultServiceConnectIfName to work with new CNI API spec #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
approved these changes
Oct 17, 2022
mythri-garaga
approved these changes
Oct 17, 2022
yinyic
added a commit
that referenced
this pull request
Oct 18, 2022
mythri-garaga
pushed a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CNI API spec now requires
ifnamelength to be <= 15 characters (containernetworking/cni#712). UpdatedefaultServiceConnectIfNameto conform to the spec.Testing
New tests cover the changes: no
Ran E2E test with test AMI and verified ingress and egress traffic for both awsvpc and bridge mode Service Connect tasks.
Description for the changelog
Update defaultServiceConnectIfName to work with new CNI API spec
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.