add version.go generation script to makefile #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the version generation for agent.
We found a bug in the agent generation process where we are not updating the short hash correctly.
Implementation details
This follows the process we use for the ecs-init version update.
Testing
tested by running
make generic-rpm-integratedwhich includes scripts/update-version.sh. Loaded the existing RPM file and started the built agent image and validated that the logs show the expected short hash of my head commit.New tests cover the changes: no
Description for the changelog
Bugfix: update ecs agent version short hash to point to built head.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.