Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CAP_CHOWN #3480

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Remove CAP_CHOWN #3480

merged 2 commits into from
Nov 10, 2022

Conversation

Realmonia
Copy link
Contributor

Summary

Remove CAP_CHOWN from docker capacity since it causes compatibility issue with legacy docker versions.

Implementation details

Testing

New tests cover the changes: N/A

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Realmonia Realmonia marked this pull request as ready for review November 10, 2022 19:46
@Realmonia Realmonia requested a review from a team as a code owner November 10, 2022 19:46
Copy link
Contributor

@yinyic yinyic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to also remove the reference

@Realmonia
Copy link
Contributor Author

Changed to a revert commit

fierlion
fierlion previously approved these changes Nov 10, 2022
yinyic
yinyic previously approved these changes Nov 10, 2022
@Realmonia Realmonia dismissed stale reviews from yinyic and fierlion via 5c8c927 November 10, 2022 20:43
@Realmonia Realmonia merged commit d367b12 into aws:dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants