SC bugfix: generate network bindings for SC containers #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With port range mapping project, we changed the way network bindings are generated for a container. We use a port set that stores singular ports for a container – the fix is to update this set for SC container too.
yinyic
approved these changes
Dec 13, 2022
YashdalfTheGray
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bug-fix: generate network bindings for SC containers
Implementation details
With port range mapping project, we changed the way network bindings are generated for a container.
We generate a port set that stores singular ports for a container, while giving
dockerPortMapto Docker.The fix here is to update this set for a SC container too. This ensures that we generate network bindings related to a SC container as well, in addition to application container.
Testing
Built an ecs-agent manually and ran SC tasks to verify that network bindings for SC container are now populated as expected. We're also working on running the functional tests related to service connect.
New tests cover the changes: no
Description for the changelog
bug-fix: generate network bindings for SC containers
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.