Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECSCNIGitHash, VPCCNIGitHash update to reflect latest commits #3531

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

SreeeS
Copy link
Contributor

@SreeeS SreeeS commented Jan 14, 2023

Summary

This update is to update the git sub modules to reflect the latest commits on amazon-ecs-cni-plugin, amazon-vpc-cni-plugins.

This change also addresses the failed static checks with message: cannot find package "golang.org/x/tools/cmd/cover"
Reference resource: https://pkg.go.dev/golang.org/x/tools/cmd/cover#section-readme

Implementation details

  1. Updated submodules to reflect latest commits on amazon-ecs-cni-plugin, amazon-vpc-cni-plugins.
  2. Updated plugin_test.go to check for the latest commits on submodules
  3. Updated Makefile: Removed go get golang.org/x/tools/cmd/cover Reason: Deprecated for Go releases 1.5 and later

Testing

  1. Confirmed the change: updated the git sub modules reflect latest commit on the fork.
  2. Tested with git workflow and bot tests

New tests cover the changes: yes

Description for the changelog

Enhancement - amazon-ecs-cni-plugins and amazon-vpc-cni-plugins git submodules to reflect latest commits
Bug - Fixed failed static checks with message: cannot find package "golang.org/x/tools/cmd/cover"

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sparrc sparrc merged commit c52c644 into aws:dev Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants