Filter out metricCount=0 and its corresponding metricValue for service connect metric TargetResponseTime #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
changed the title
ubhattacharjya
force-pushed
the
filterTargetResponseTime
branch
from
ea109f7
to
74cc444
Compare
ubhattacharjya
force-pushed
the
filterTargetResponseTime
branch
2 times, most recently
from
5660edf
to
7ca989b
Compare
yinyic
reviewed
Jan 20, 2023
sparrc
reviewed
Jan 20, 2023
ubhattacharjya
force-pushed
the
filterTargetResponseTime
branch
from
7ca989b
to
c884cb1
Compare
yinyic
previously approved these changes
Jan 20, 2023
mythri-garaga
previously approved these changes
Jan 20, 2023
ubhattacharjya
dismissed stale reviews from mythri-garaga and yinyic
via
943121b
ubhattacharjya
force-pushed
the
filterTargetResponseTime
branch
2 times, most recently
from
943121b
to
2cf0d58
Compare
yinyic
previously approved these changes
Jan 20, 2023
rajal-amzn
previously approved these changes
Jan 20, 2023
…e connect metric TargetResponseTime
ubhattacharjya
dismissed stale reviews from rajal-amzn and yinyic
via
c00164b
ubhattacharjya
force-pushed
the
filterTargetResponseTime
branch
from
2cf0d58
to
c00164b
Compare
yinyic
approved these changes
Jan 20, 2023
karanvasnani
approved these changes
Jan 20, 2023
| metricValues, metricCounts = convertHistogramMetricCounts(metricValues, metricCounts) | ||
|
|
||
| // If all values are 0 in metricCount, then no need to send the metrics to TACS | ||
| if len(metricCounts) == 0 { |
There was a problem hiding this comment.
As an optimization we can pre-compute this by checking the SampleCount value to be 0 (metric.Histogram.SampleCount I think) on L99 and completely skip processing these completely empty buckets?
There was a problem hiding this comment.
sure. I would take this up as a follow-up task and address that in a separate PR.
rajal-amzn
approved these changes
Jan 20, 2023
mythri-garaga
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters out all metric Counts for the histogram metric TargetResponseTime which are 0. We also remove the corresponding metricValues.
This is because when there is no traffic and metricCount is 0, the dashboards incorrectly show min as 0 and max as 360000. In this case, there should have been no datapoints. For example,
Before:
MetricCounts: [8, 0, 3, 0, 0, 0, 1, 0, 0, 0, 0, 0,0, 0, 0, 0, 0, 0, 0 ]
MetricValues: [ 0.5, 1, 5, 10, 25, 50, 100, 250, 500, 1000, 2500, 5000, 10000, 30000, 60000, 300000, 600000, 1.8e+06, 3.6e+06 ]}
This Pr correctly sends only non-zero metric counts and now it looks like below.
After:
MetricCounts: [8, 3, 1]
MetricValues: [0.5, 5, 100]}
Summary
Implementation details
Testing
New tests cover the changes: yes
In the summary the test results are mentioned
Description for the changelog
BugFix: Filter out metricCount=0 and its corresponding metricValue for service connect metric TargetResponseTime
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.