-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go module dependencies #3593
Conversation
…and go version in go.mod
Thanks for raising this PR!
Just for my reference and understanding, what would the impact be of leaving ecs-init's go mod version as 1.17? Phrased differently, are there any specific issues/concerns we address by updating ecs-init's go mod version to 1.19 other than simply matching Agent's go mod version? |
nit: Per our offline discussions, 4/5 of these updates are security updates. For context purposes, could we update the PR description to indicate that? |
the go version in go mod file specifies the minimum go version required to build packages in a module. Ref: https://go.dev/doc/modules/gomod-ref#go so its more to do with keeping up-to date with the latest version and less to do with keeping the agent and init module versions in sync actually. |
Summary
This PR updates go module dependencies in both the agent and init packages. Dependabot currently has 5 open PRs that's trying to do these updates but failing.
Implementation details
This PR has 5 commits, updating one dependency in each commit, made easy for you to review.
Helps us close #3578.
Helps us close #3573.
Helps us close #3574 and I also updated init's go mod version from 1.17 -> 1.19 to match agent's go mod version.
Helps us close #3572.
Helps us close #3339.
The following commands were run, to update all the dependencies above:
Note:
go mod vendor
on tip of dev branch pulls in some newgit.luolix.top/docker/docker
changes. These changes lead to failed tests on Windows. The docker module update is being dealt with in PR #3557 and this PR does not touch it.All except [5] are security updates. Dependabot has an open issue/PFR where it does not honor the dependabot config settings for security updates: dependabot/dependabot-core#2767. It opens multiple PRs against "master" which is our default branch. Whereas we'd like to pull in the updates to "dev" first, so a human intervention is necessary.
Testing
New tests cover the changes: no
Description for the changelog
Enhancement: update go module dependencies
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.