Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go module dependencies #3593

Merged
merged 5 commits into from
Mar 1, 2023
Merged

update go module dependencies #3593

merged 5 commits into from
Mar 1, 2023

Conversation

singholt
Copy link
Contributor

@singholt singholt commented Feb 26, 2023

Summary

This PR updates go module dependencies in both the agent and init packages. Dependabot currently has 5 open PRs that's trying to do these updates but failing.

Implementation details

This PR has 5 commits, updating one dependency in each commit, made easy for you to review.

  1. agent: update golang.org/x/net from v0.5.0 -> v0.7.0

Helps us close #3578.

  1. agent: update github.com/containerd/containerd from v1.4.13 -> v1.5.18

Helps us close #3573.

  1. init: update github.com/containerd/containerd from v1.6.8 -> v.16.18

Helps us close #3574 and I also updated init's go mod version from 1.17 -> 1.19 to match agent's go mod version.

  1. agent: update github.com/prometheus/client_golang from v1.7.1 -> v1.11.1

Helps us close #3572.

  1. agent: update github.com/gorilla/websocket from v1.4.2 -> v1.5.0

Helps us close #3339.

The following commands were run, to update all the dependencies above:

1. In go.mod file, update the target dependency from X to Y.
2. go mod tidy
3. go mod vendor

Note: go mod vendor on tip of dev branch pulls in some new github.com/docker/docker changes. These changes lead to failed tests on Windows. The docker module update is being dealt with in PR #3557 and this PR does not touch it.

All except [5] are security updates. Dependabot has an open issue/PFR where it does not honor the dependabot config settings for security updates: dependabot/dependabot-core#2767. It opens multiple PRs against "master" which is our default branch. Whereas we'd like to pull in the updates to "dev" first, so a human intervention is necessary.

Testing

New tests cover the changes: no

Description for the changelog

Enhancement: update go module dependencies

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@singholt singholt changed the title [wip] update golang.org/x/net from v0.5.0 -> v0.7.0 [wip] update go module dependencies Feb 26, 2023
@singholt singholt changed the title [wip] update go module dependencies update go module dependencies Feb 26, 2023
@singholt singholt marked this pull request as ready for review February 26, 2023 01:43
@singholt singholt requested a review from a team as a code owner February 26, 2023 01:43
@danehlim
Copy link
Contributor

danehlim commented Mar 1, 2023

Thanks for raising this PR!

I also updated init's go mod version from 1.17 -> 1.19 to match agent's go mod version.

Just for my reference and understanding, what would the impact be of leaving ecs-init's go mod version as 1.17? Phrased differently, are there any specific issues/concerns we address by updating ecs-init's go mod version to 1.19 other than simply matching Agent's go mod version?

@danehlim
Copy link
Contributor

danehlim commented Mar 1, 2023

nit: Per our offline discussions, 4/5 of these updates are security updates. For context purposes, could we update the PR description to indicate that?

@singholt
Copy link
Contributor Author

singholt commented Mar 1, 2023

Just for my reference and understanding, what would the impact be of leaving ecs-init's go mod version as 1.17? Phased differently, are there any specific issues/concerns we address by updating ecs-init's go mod version to 1.19 other than simply matching Agent's go mod version?

the go version in go mod file specifies the minimum go version required to build packages in a module. Ref: https://go.dev/doc/modules/gomod-ref#go

so its more to do with keeping up-to date with the latest version and less to do with keeping the agent and init module versions in sync actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants