Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets for ecs-agent module and integrate it with CI #3651

Merged
merged 8 commits into from
Apr 24, 2023

Conversation

amogh09
Copy link
Contributor

@amogh09 amogh09 commented Apr 21, 2023

Summary

Update make targets to include ecs-agent module. Integrate ecs-agent module with CI.

Implementation details

  • Added a simple utility function with tests to ecs-agent module.
  • Updated existing make targets for agent module to include ecs-agent module.
    • make test now runs tests for ecs-agent too, and outputs coverage data to coverprofile-ecs-agent.out file.
    • make analyze-cover-profile now analyzes test coverage for ecs-agent module too.
    • make clean now cleans up coverage data file for ecs-agent tests too.
    • make static-check now runs static checks for ecs-agent module too.
  • The test coverage analysis script scripts/analyze-cover-profile-init˙ is a duplicate of scripts/analyze-cover-profile`. Removed the former and updated the latter to take test coverage file as input. Updated static check CI workflow to pass the coverage file to the script.
  • Updated Windows tests workflow to run tests for ecs-agent module too.

Testing

Checked CI workflow logs that tests are run for ecs-agent module. Also checked that static-check is run for ecs-agent module in the CI workflow logs.

New tests cover the changes: yes

Description for the changelog

Integrate ecs-agent module with CI. Add make targets for ecs-agent module.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amogh09 amogh09 marked this pull request as ready for review April 21, 2023 16:19
@amogh09 amogh09 requested a review from a team as a code owner April 21, 2023 16:19
@amogh09 amogh09 changed the title Add mux utils to ecs-agent and make target for running ecs-agent tests Set up ecs-agent module with a basic util and test Apr 21, 2023
@amogh09 amogh09 changed the title Set up ecs-agent module with a basic util and test Set up testing for ecs-agent module Apr 21, 2023
Copy link
Contributor

@danehlim danehlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update the make clean target to remove the coverprofile-ecs-agent.out file as well?

Makefile Outdated Show resolved Hide resolved
danehlim
danehlim previously approved these changes Apr 21, 2023
danehlim
danehlim previously approved these changes Apr 21, 2023
@amogh09 amogh09 changed the title Set up testing for ecs-agent module WIP: Set up ecs-agent module Apr 21, 2023
@amogh09 amogh09 changed the title WIP: Set up ecs-agent module Add make targets for ecs-agent module and integrate it with CI Apr 21, 2023
Copy link
Contributor

@danehlim danehlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

Not blocking to this PR, but I think we'll want to revisit outstanding make targets that contain ./agent/... and see if we want to include ./ecs-agent/... as well (e.g., make benchmark-test). Let's make sure we're tracking this somewhere internally.

@amogh09
Copy link
Contributor Author

amogh09 commented Apr 21, 2023

Thanks! Yeah I think we would want to look at the other targets on a case-by-case basis and update the ones we think are applicable to ecs-agent module.

@amogh09 amogh09 merged commit fb5096f into aws:dev Apr 24, 2023
@amogh09 amogh09 deleted the ecs-agent-mod-start branch April 24, 2023 21:17
@Yiyuanzzz Yiyuanzzz mentioned this pull request Apr 26, 2023
Realmonia pushed a commit to Realmonia/amazon-ecs-agent that referenced this pull request May 16, 2023
Realmonia pushed a commit to Realmonia/amazon-ecs-agent that referenced this pull request May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants