Move container instance health doctor to ecs-agent/ #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
force-pushed
the
containerinstancehealth
branch
from
9d18c68
to
7be3ec2
Compare
amogh09
reviewed
May 1, 2023
danehlim
force-pushed
the
containerinstancehealth
branch
from
7be3ec2
to
8eeed9e
Compare
amogh09
previously approved these changes
May 1, 2023
danehlim
force-pushed
the
containerinstancehealth
branch
from
8eeed9e
to
2729c88
Compare
danehlim
force-pushed
the
containerinstancehealth
branch
from
2729c88
to
d8e43dd
Compare
YashdalfTheGray
previously approved these changes
May 1, 2023
amogh09
previously approved these changes
May 1, 2023
danehlim
force-pushed
the
containerinstancehealth
branch
from
d8e43dd
to
c589881
Compare
amogh09
approved these changes
May 1, 2023
YashdalfTheGray
approved these changes
May 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move doctor (container instance health) to
ecs-agent/and reformat accordingly.NOTE: An interface for logging to be used in
ecs-agent/will be added as part of a future PR and is out of scope of this PR. For now, we continue to leverage our existing dependency on seelog in the ecs-agent module.Implementation details
agent/doctor/doctor.go,agent/doctor/doctor_test.go,agent/doctor/healthcheck.go,agent/doctor/healthcheckstatus.go, andagent/doctor/healthcheckstatus_test.gotoecs-agent/doctor/directorygit.luolix.top/aws/amazon-ecs-agent/agent/doctorwithgit.luolix.top/aws/amazon-ecs-agent/ecs-agent/doctorand then resort importsgit.luolix.top/aws/amazon-ecs-agent/agent/doctorbut still have a dependency onagent/doctor/docker_runtime_healthcheck.go, reimportgit.luolix.top/aws/amazon-ecs-agent/agent/doctorwith aliasdockerdoctor(to avoid package name conflict withgit.luolix.top/aws/amazon-ecs-agent/ecs-agent/doctor)github.com/aws/amazon-ecs-agent/ecs-agent/doctoris for general container instance health check functionality and constantsgit.luolix.top/aws/amazon-ecs-agent/agent/doctoris for container instance health check things that are specific to our Agent, such as Docker health checks (since our Agent is Docker based)agent/directory and rungo mod tidyandgo mod vendorecs-agent/directory and rungo mod tidyandgo mod vendorTesting
Unit, integration, and functional tests.
Description for the changelog
Move container instance health doctor to ecs-agent/
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.