Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools.go documentation + remove agent/acs/model #3670

Merged
merged 2 commits into from
May 3, 2023

Conversation

danehlim
Copy link
Contributor

@danehlim danehlim commented May 3, 2023

Summary

This pull request is a follow up to #3659.

Add some comments in tools.go files' code to provide more context on their usage (motivation: #3659 (comment)).

Remove unused agent/acs/model directory and all of its files. Despite this step being included in the PR description of #3659, this step was missed in the actual changes (i.e., only some files in agent/acs/model were deleted).

Implementation details

  1. Update inline tools.go documentation
    • Add comments in code to provide context on usage of agent/tools.go and ecs-agent/tools.go
  2. Remove unused agent/acs/model
    • Delete agent/acs/model directory and all of its files

Testing

PR tests (unit, integration, and functional).

New tests cover the changes: N/A

Description for the changelog

Update tools.go documentation + remove agent/acs/model

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim marked this pull request as ready for review May 3, 2023 20:33
@danehlim danehlim requested a review from a team as a code owner May 3, 2023 20:33
@danehlim danehlim merged commit 66ee03d into aws:dev May 3, 2023
@Realmonia Realmonia mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants