Add default AES256 encryption and enable versioning for buckets in audit-logs, release-pipeline, and staging-bucket stacks #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
approved these changes
May 4, 2023
prateekchaudhry
approved these changes
May 4, 2023
Merged
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 16, 2023
Realmonia
pushed a commit
to Realmonia/amazon-ecs-agent
that referenced
this pull request
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add default AES256 encryption and enable versioning for buckets in audit-logs, release-pipeline, and staging-bucket CFN templates. AES256 Encryption is already enabled on the buckets by default so the encryption change in the stack template should be a no-op. Versioning will be enabled when the stack is updated.
Only the release-pipeline stack actually exists, so we will only update that stack.
Implementation details
Update the CFN templates with
BucketEncryptionandVersioningConfigurationproperties.Testing
New tests cover the changes: no
Description for the changelog
Add default AES256 encryption and enable versioning for buckets in audit-logs, release-pipeline, and staging-bucket stacks.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.