Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/channelBasedStatsEngine to dev #3717

Merged
merged 2 commits into from
May 25, 2023

Conversation

Realmonia
Copy link
Contributor

@Realmonia Realmonia commented May 25, 2023

Summary

Changes to change the communication between TCS Client and Docker Stats Engine to channel based. This is merging feature branch to dev. This will be a rebase merge to keep commit history in feature branch.

#3646
#3683

Implementation details

Testing

New tests cover the changes: Yes

See in individual commits

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Realmonia added 2 commits May 25, 2023 11:11
…ng channels to statsEngine (#3646)

* Move statsEngine initiation from tcs session initialization, and adding channels to statsEngine
…> TCSClient) (#3683)

* Channel based docker stats engine implementation (DockerStatsEngine -> TCSClient)
@Realmonia Realmonia requested a review from a team as a code owner May 25, 2023 18:51
@singholt
Copy link
Contributor

can you add links to PRs in the description?

@Realmonia Realmonia merged commit bc8945d into dev May 25, 2023
@yinyic yinyic mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants