Feature/ecs domainless gmsa #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added gMSA linux domainless capbility 2. gRPC endpoint
arun-annamalai
force-pushed
the
feature/ecs-domainless-gmsa
branch
from
4fec6dc
to
bbc4a3f
Compare
saikiranakula-amzn
approved these changes
Jun 5, 2023
amogh09
approved these changes
Jun 5, 2023
mythri-garaga
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change implements the domainless gMSA support on windows/linux
Advertise Domainless gMSA capability on Windows #3668
Client Model changes to parse credentialSpecs #3671
Plumb credentialSpecs field into container #3675
Domainless gMSA linux capability and gRPC endpoints #3678
Add gMSA domainless support #3689
Inject domainless gmsa cred spec into Windows Container #3682
Refresh Windows Domainless gMSA plugin credentials #3703
Refresh handler gmsa linux #3709
Added integration test gMSA domainless #3728
Implementation details
The changes have already been through individual reviews. The changes are implemented by receiving an additional field from the task definition so that the respective Windows/Linux plugins can inject containers with the kerberos ticket for gMSA.
Testing
This was tested using both unit,integration, MACIS tests
There was also an ECS agent test plan meeting
New tests cover the changes:
yes
Description for the changelog
Add support for domainless gMSA on Windows and Linux
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.