Improve test coverage of v2, v3, and v4 container stats endpoints #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singholt
approved these changes
Jun 22, 2023
chienhanlin
approved these changes
Jun 23, 2023
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 26, 2023
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve test coverage for v2, v3, and v4 container stats endpoints.
This change is in a series of test coverage improvements we are making for TMDS endpoints. Test coverage is being improved to gain more confidence in the ongoing TMDS refactoring work.
Some previous PRs in this series are #3729, #3722, and #3708. All happy and error cases are consolidated into one test function per endpoint.
Implementation
TMDSTestCasetype andtestTMDSRequestfunction to support setting expectations on mock Stats Engine.TMDSResponseinterface to support container stats endpoints' response types.TestV2ContainerStats,TestV3ContainerStats, andTestV4ContainerStatsfunctions that only test happy cases with new functions that test all error and happy cases.Testing
New tests cover the changes: NA
Description for the changelog
Improve test coverage of v2, v3, and v4 container stats endpoints
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.