Move TMDS task protection types to ecs-agent #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
changed the title
amogh09
force-pushed
the
move-task-protection-types
branch
from
1568feb
to
db1d52c
Compare
amogh09
changed the title
amogh09
force-pushed
the
move-task-protection-types
branch
from
58635cc
to
58318ea
Compare
mye956
reviewed
Jun 28, 2023
mye956
approved these changes
Jun 28, 2023
Realmonia
approved these changes
Jun 28, 2023
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
Jun 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving types related to TMDS task protection endpoint to ecs-agent module. Task protection endpoint handlers will be moved to ecs-agent module in an upcoming PR.
Implementation details
agent/handlers/agentapi/taskprotection/v1/types/types.gotoecs-agent/tmds/handlers/taskprotection/v1/types/types.go.TaskProtectionClientFactoryInterfacefromagent/handlers/agentapi/taskprotection/v1/handlers/handlers.gotoecs-agent/tmds/handlers/taskprotection/v1/handlers/interface.go.TaskProtectionClientFactorythat implementsTaskProtectionClientFactoryInterfacefromagent/handlers/agentapi/taskprotection/v1/handlers/handlers.goto a new fileagent/handlers/agentapi/taskprotection/factory.go. Similarly, move its testTestGetECSClientHappyCasefromagent/handlers/agentapi/taskprotection/v1/handlers/handlers_test.gotoagent/handlers/agentapi/taskprotection/factory_test.go.Testing
Automated tests only.
New tests cover the changes: NA
Description for the changelog
Move TMDS task protection types to ecs-agent (refactoring only).
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.