EBS volume stats implementation #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
force-pushed
the
ebs-volume-stats
branch
2 times, most recently
from
2dc4be5
to
d710dc4
Compare
xxx0624
force-pushed
the
ebs-volume-stats
branch
2 times, most recently
from
4997357
to
7b519ed
Compare
xxx0624
changed the title
xxx0624
force-pushed
the
ebs-volume-stats
branch
from
181db56
to
bb70114
Compare
amogh09
reviewed
Jul 5, 2023
amogh09
reviewed
Jul 5, 2023
xxx0624
force-pushed
the
ebs-volume-stats
branch
3 times, most recently
from
70dd273
to
60bf23e
Compare
xxx0624
force-pushed
the
ebs-volume-stats
branch
from
60bf23e
to
c6731bb
Compare
amogh09
approved these changes
Jul 10, 2023
fierlion
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the implementation for the EBS volume stats.
Implementation details
The implementation is same as the volume stats implementation of the existing AWS ebs csi driver implementation (https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/pkg/driver/node.go#L474).
And add one rule to build the tar file.
Testing
New tests cover the changes: yes
Also
csidriverare pass viamake test.Description for the changelog
Add EBS volume stats implementation in the csi driver daemon.
Add one makefile rule to build the tar file.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.