broadcast FSx capability by default for Windows #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-annamalai
previously approved these changes
Jun 30, 2023
jterry75
approved these changes
Jul 3, 2023
singholt
reviewed
Jul 5, 2023
rawahars
force-pushed
the
dev
branch
4 times, most recently
from
dd0d4ca
to
fc2074f
Compare
singholt
reviewed
Jul 6, 2023
arun-annamalai
previously approved these changes
Jul 6, 2023
singholt
previously approved these changes
Jul 6, 2023
singholt
previously approved these changes
Jul 6, 2023
singholt
reviewed
Jul 6, 2023
Presently, the logic for enabling FSx on the instance requires the instance to be domain joined with the AD. However, in essence this is not needed for enabling just FSx capability. If a customer has setup their DHCP option set for their AD, then FSx can work on their instances even without a domain join. Reference- https://docs.aws.amazon.com/directoryservice/latest/admin-guide/dhcp_options_set.html Therefore, we will enable FSx capability by default. The customer can explicitly disable it by setting `ECS_FSX_WINDOWS_FILE_SERVER_SUPPORTED` as false.
singholt
approved these changes
Jul 6, 2023
Realmonia
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Presently, the logic for enabling FSx on the instance requires the instance to be domain joined with the AD. This behaviour was fixed in #3540.
However, this is not needed for enabling just FSx capability. If a customer has setup their DHCP option set for their AD, then FSx can work on their instances even without a domain join. Reference- https://docs.aws.amazon.com/directoryservice/latest/admin-guide/dhcp_options_set.html
Therefore, we will enable FSx capability by default. The customer can explicitly disable it by setting
ECS_FSX_WINDOWS_FILE_SERVER_SUPPORTEDas false.Implementation details
Removed the dependency of FSx capability on instance domain join.
Testing
Created a custom agent and ran a FSx enabled task without domain join of the instance.
New tests cover the changes:
Description for the changelog
enable FSx capability by default for Windows
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.