Revert task resource accounting #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekchaudhry
approved these changes
Jun 30, 2023
Yiyuanzzz
approved these changes
Jun 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Revert task resource accounting changes. There is a small chance that ECS's scheduling backend can "oversubscribe" an instance, thereby sending it more tasks than it is supposed to have resources for.
Although this is a mistake, agent would allow this to happen and run the task anyways.
Now the tasks are getting stuck in PENDING, which is arguably a worse behavior for agent to take (rather than run anyways or fail the task).
Testing
New tests cover the changes:
Description for the changelog
Bugfix: revert task resource accounting to avoid tasks stuck in PENDING on oversubscribed instance.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.