Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daemon manager with basic instance task creation #3789

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

fierlion
Copy link
Member

@fierlion fierlion commented Jul 7, 2023

Summary

This commit adds the daemonmanager package which will be used by the Agent to create internal managed daemon tasks/containers. It also expands the managed daemon definition and setup with additional functions to create and validate the daemons.

Implementation details

Managed Daemons now have setup validation requirements in their required mount points and healthcheck. Once a daemon is successfully created, it should be registered with its own daemon manager object. This object exposes methods to create the internal managed daemon task.

Still to come are the daemon configuration and tar files (see inline TODOs in ManagedDaemon.ImportAll()) and also integration with the agent startup and attachment/task payload handlers to create and add the daemons to the Agent's managed task set.

Note that much of this is borrowing heavily from the service connect manager: https://github.com/aws/amazon-ecs-agent/blob/master/agent/engine/serviceconnect/manager_linux.go#L299

Testing

Added new unit tests for all functions.

New tests cover the changes: Yes

Description for the changelog

Add daemon manager package with initial daemon task creation methods.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fierlion fierlion requested a review from a team as a code owner July 7, 2023 20:09
@fierlion fierlion merged commit 9de5ab7 into aws:dev Jul 11, 2023
6 checks passed
@fierlion fierlion deleted the fierlion/DaemonManager branch July 11, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants