Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACS attach resource responder to ecs-agent #3807

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

danehlim
Copy link
Contributor

@danehlim danehlim commented Jul 17, 2023

Summary

Add ACS attach resource responder and other associated code it is dependent on to ecs-agent/. This ACS message responder handles attach resource messages (i.e., type ConfirmAttachmentMessage) from ACS. Resources associated with such messages are non-ENI and can be specific to Fargate launch type.

For clarity, this pull request just adds functionality to the ecs-agent module and does NOT change the agent module in any way to use this functionality. That is, in this pull request, the ACS attach resource responder defined in ecs-agent/ is NOT integrated into our Agent defined in agent/.

Implementation details

  1. Add attach resource responder to ecs-agent/acs/session/ directory
  2. Add resource models which attach resource responder is dependent on to ecs-agent/api/resource/ directory
  3. Update ecs-agent/metrics/constants.go with constants specific to attach resource responder

Testing

Unit, integration, and functional tests.

New tests cover the changes: yes

Description for the changelog

Add ACS attach resource responder to ecs-agent

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim marked this pull request as ready for review July 18, 2023 17:09
@danehlim danehlim requested a review from a team as a code owner July 18, 2023 17:09
@danehlim danehlim merged commit 11ad1e0 into aws:dev Jul 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants