Add ACS attach resource responder to ecs-agent #3807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add ACS attach resource responder and other associated code it is dependent on to
ecs-agent/
. This ACS message responder handles attach resource messages (i.e., typeConfirmAttachmentMessage
) from ACS. Resources associated with such messages are non-ENI and can be specific to Fargate launch type.For clarity, this pull request just adds functionality to the ecs-agent module and does NOT change the agent module in any way to use this functionality. That is, in this pull request, the ACS attach resource responder defined in
ecs-agent/
is NOT integrated into our Agent defined inagent/
.Implementation details
ecs-agent/acs/session/
directoryecs-agent/api/resource/
directoryecs-agent/metrics/constants.go
with constants specific to attach resource responderTesting
Unit, integration, and functional tests.
New tests cover the changes: yes
Description for the changelog
Add ACS attach resource responder to ecs-agent
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.