Add some unit tests for config parsers where coverage was missing #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
unit-tests-for-envvar-parsers
branch
2 times, most recently
from
7f210b3
to
0696bc5
Compare
before: % go test -cover -tags unit ./config/. ok github.com/aws/amazon-ecs-agent/agent/config 0.460s coverage: 91.0% of statements after: % go test -cover -tags unit ./config/. ok github.com/aws/amazon-ecs-agent/agent/config 0.480s coverage: 92.6% of statements
sparrc
force-pushed
the
unit-tests-for-envvar-parsers
branch
from
0696bc5
to
03eacd3
Compare
sparrc
force-pushed
the
unit-tests-for-envvar-parsers
branch
from
03eacd3
to
2d20134
Compare
sparrc
force-pushed
the
unit-tests-for-envvar-parsers
branch
from
2d20134
to
c8b3847
Compare
Yiyuanzzz
approved these changes
Jul 19, 2023
singholt
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some env var config parsing situations were missing coverage, adding unit tests for fuller coverage. Some unit test files were also missing the "unit" tag, which meant they were not running on PRs. Tags were added to these files.
before:
after:
Testing
n/a
Description for the changelog
no application code changes
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.