Increase test coverage of some ACS responders #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
force-pushed
the
increasetestcoverage
branch
from
09565fc
to
64330db
Compare
danehlim
force-pushed
the
increasetestcoverage
branch
from
64330db
to
5ab51b7
Compare
ubhattacharjya
approved these changes
Jul 25, 2023
Yiyuanzzz
approved these changes
Jul 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test coverage in ecs-agent module for some ACS responders are lower than the module's current
MINIMUM_TEST_COVERAGEdefined here. Currently, most areas where coverage is missing in the ecs-agent module for ACS message responders are actually tested in the agent module. Nevertheless, we should still add some further standalone testing to the ecs-agent module as it is its own separate module and the tests in agent module are not accounted for in the calculation of test coverage of ecs-agent module.This pull request adds additional testing specifically for the attach task ENI, attach instance ENI, and attach resource responders in the ecs-agent module. Further testing may be added in future pull request(s).
No functionality aside from testing is modified as part of this pull request.
Implementation details
testconst.ContainerInstanceARNvalue to be a legitimate/valid container instance ARN instead of just hardcoded textgo mod tidyandgo mod vendorwere run and ended up modifying theagent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/tmds/handlers/v4/state/response.gofile as a result of a previous PRTesting
Existing unit, integration, and functional tests.
New tests cover the changes: yes
Description for the changelog
Increase test coverage of some ACS responders
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.