Move appnet client interface to ecs-agent #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
July 20, 2023 12:01
RichaGangwar
changed the title
Realmonia
approved these changes
Jul 26, 2023
danehlim
reviewed
Jul 28, 2023
yinyic
approved these changes
Jul 28, 2023
danehlim
approved these changes
Jul 31, 2023
chienhanlin
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Move appnet client lib to ecs-agent * Removed updated version on dependencies in go.mod for agent and ecs-agent * appnet client: changes for shared lib * appnet client: shared lib * appnet client: shared lib * appnet client: new mocks * appnet client: new mocks * appnet client: add generate_mocks to agent vendor * appnet client: remove arguments passed to createclient * appnet client: updated api mock * appnet client: Fix name on service_connect_linux * Remove ECSTaskProtectionSDK from interface.go * Update mocks * AppnetClient: Updated interface to remove appnet * Updated api mocks * Fix go imports * AppnetClient: Update files in vendor dir * AppnetClient: Update import for mock appnet client * Test fix --------- Co-authored-by: Richa Gangwar <ricgang@amazon.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves Appnet client interface to ecs-agent. The PR also makes minor changes in order to make the library shareable.
Implementation details
Testing
Tested using existing test cases as no new functionality is introduced.
New tests cover the changes: no
Description for the changelog
Move appnet client interface to ecs-agent
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.