Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume metrics for CSI client #3884

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add volume metrics for CSI client #3884

merged 1 commit into from
Sep 1, 2023

Conversation

xxx0624
Copy link
Contributor

@xxx0624 xxx0624 commented Aug 31, 2023

Summary

This CSI client encapsulates all things needed to communicate with the CSI driver daemon. As part of the client, this method GetVolumeMetrics can be used to get the given EBS volume stats. With this PR, we introduce a new struct to include more stats.

Implementation details

A new struct is added which include the Capacity and Used metrics for EBS volume.

Testing

New tests cover the changes: no

Run go mod vendor for both agent/ and ecs-agent/.

Description for the changelog

Update GetVolumeMetrics in the CSI client.

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xxx0624 xxx0624 requested a review from a team as a code owner August 31, 2023 19:47
Copy link
Contributor

@mye956 mye956 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be used somewhere within the /agent directory in a future PR (or if it is already being used)? If so, we probably should also do a go mod vendor.

@xxx0624
Copy link
Contributor Author

xxx0624 commented Aug 31, 2023

Will these be used somewhere within the /agent directory in a future PR (or if it is already being used)? If so, we probably should also do a go mod vendor.

Yes (not used for now). And I've run this for both agent/ and ecs-agent/

@fierlion fierlion merged commit 39f1f9c into aws:dev Sep 1, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants